Merge pull request #199 from outis1one/claude/asterisk-digital-ocean-w22kk8

Fix install function name mismatch for security-dashboard
This commit is contained in:
Outis
2026-07-21 16:21:35 -04:00
committed by GitHub
2 changed files with 8 additions and 3 deletions
+6 -1
View File
@@ -17,7 +17,12 @@ checklist per group, and calls `install_<name>()` for each selected item.
1. Create `services/<name>.sh` (kebab-case filename)
2. Call `register_service` at the top of the file
3. Define `install_<name>()` (hyphens → underscores in function name)
3. Define `install_<name>()` — keep hyphens **literal** in the function name
(`install_asterisk-digital-ocean`, not `install_asterisk_digital_ocean`).
`setup.sh`'s dispatcher calls `install_${name}` with no hyphen→underscore
conversion, so the function name must match the service name exactly.
Confirmed live: a mismatched underscore here produces
`Service 'x' has no install_x` at runtime, not a load-time error.
That's it. The menu picks it up on the next run.
+2 -2
View File
@@ -66,7 +66,7 @@ fi
register_service security-dashboard homelab "Security dashboard: Asterisk failed-connections + CrowdSec bans (Authelia-protected)" 8092
install_security_dashboard() {
install_security-dashboard() {
local APP_DIR="/opt/security-dashboard"
local DASHBOARD_PORT=8092
local ASTERISK_LOG_DIR="$DOCKER_DIR/asterisk-digital-ocean/logs"
@@ -682,4 +682,4 @@ if __name__ == "__main__":
PYAPP
}
[[ "${_RUN_STANDALONE:-0}" == 1 ]] && install_security_dashboard
[[ "${_RUN_STANDALONE:-0}" == 1 ]] && install_security-dashboard