Disambiguate manage.sh controllers wording: client vs controller
Live user feedback: "Exactly one client is actively streaming right now" sitting directly above "How many controller slots" read as "only one controller is connected" - an easy misread since "client" (a paired Moonlight session/device) and "controller" (a physical gamepad slot within that session) are conflated by ordinary English but mean completely different things here. The tool has no way to detect controller count at all; it only ever picks which Moonlight session/device to configure. Reworded every message in this flow to say "Moonlight session/device" instead of bare "client", and added an explicit line before the controller-count prompt clarifying it's a separate question the user has to answer themselves. Verified the full flow still runs correctly end to end against the same mocked duplicate-heavy client data used earlier. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLX1yYKJExGSXmgUhxKQG6
This commit is contained in:
+10
-4
@@ -3415,14 +3415,17 @@ print(next(iter(ids)) if len(ids) == 1 else '')
|
||||
if [ -n "$ACTIVE_CLIENT_ID" ]; then
|
||||
CLIENT_ID="$ACTIVE_CLIENT_ID"
|
||||
echo ""
|
||||
echo "Exactly one client is actively streaming right now — using that one."
|
||||
echo "Exactly one Moonlight session (device/TV) is actively streaming right"
|
||||
echo "now — using that one. (This is about which SCREEN/DEVICE you're"
|
||||
echo "configuring, not how many controllers are plugged into it — that's"
|
||||
echo "the next question.)"
|
||||
elif [ "${#CLIENT_IDS[@]}" -eq 1 ]; then
|
||||
CLIENT_ID="${CLIENT_IDS[0]}"
|
||||
echo ""
|
||||
echo "Only one paired client — using it."
|
||||
echo "Only one paired Moonlight device — using it."
|
||||
else
|
||||
echo ""
|
||||
read -r -p "Which client [1-${#CLIENT_IDS[@]}]: " PICK
|
||||
read -r -p "Which Moonlight session/device [1-${#CLIENT_IDS[@]}]: " PICK
|
||||
if ! [[ "$PICK" =~ ^[0-9]+$ ]] || [ "$PICK" -lt 1 ] || [ "$PICK" -gt "${#CLIENT_IDS[@]}" ]; then
|
||||
echo "Invalid selection."
|
||||
exit 1
|
||||
@@ -3431,7 +3434,10 @@ print(next(iter(ids)) if len(ids) == 1 else '')
|
||||
fi
|
||||
|
||||
echo ""
|
||||
read -r -p "How many controller slots to force a type for [2]: " NSLOTS
|
||||
echo "Now, separately: how many physical GAMEPADS/CONTROLLERS do you have"
|
||||
echo "connected to that device right now (this tool can't detect that —"
|
||||
echo "count your own controllers)?"
|
||||
read -r -p "Number of controllers [2]: " NSLOTS
|
||||
NSLOTS="${NSLOTS:-2}"
|
||||
if ! [[ "$NSLOTS" =~ ^[0-9]+$ ]] || [ "$NSLOTS" -lt 1 ]; then
|
||||
echo "Invalid number."
|
||||
|
||||
Reference in New Issue
Block a user