root/silent-send
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wrap fetch interceptor in top-level try/catch to prevent breaking page requests

Browse Source 
If anything in Silent Send's substitution logic throws (bad mapping,
regex error, unexpected body format, etc.), the exception was propagating
up to the caller instead of falling through to the original fetch. This
broke Claude Code's web interface (claude.ai/code) when a bad mapping
caused a substitution error mid-request.

The inner try/catch on JSON.parse only covered the JSON path — the outer
logic (hasSubstitutions, processBody, notifySubstitutions, etc.) had no
protection. Added a top-level try/catch that catches any unhandled error
and falls through to originalFetch, logging a warning so the error is
still visible in the console.

https://claude.ai/code/session_01CwcZK8nqL8pyBH9AxDs9qo
This commit is contained in:
Claude
2026-04-02 13:23:33 +00:00
parent 3d8642db52
commit 617a2d10eb
1 changed files with 66 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/content/content.js
+66 -59
View File
@@ -825,67 +825,74 @@
}
window.__ssInterceptFetch = async function (url, options) {
if (!settings.enabled || !hasSubstitutions()) {
// Top-level guard: any unhandled error must never break the original request.
try {
if (!settings.enabled || !hasSubstitutions()) {
return originalFetch.call(this, url, options);
}
const urlStr = typeof url === 'string' ? url : url?.url || '';
const method = (options?.method || 'GET').toUpperCase();
// Only intercept POST/PUT/PATCH
if (
(method === 'POST' || method === 'PUT' || method === 'PATCH') &&
options?.body && !shouldSkipUrl(urlStr)
) {
// FormData body — scan file uploads via DocumentScanner
if (options.body instanceof FormData && typeof globalThis.DocumentScanner !== 'undefined') {
try {
const scannedForm = await scanFormData(options.body);
if (scannedForm) {
options = { ...options, body: scannedForm.formData };
if (scannedForm.replacements.length > 0) {
notifySubstitutions(scannedForm.replacements);
console.log(
`[Silent Send] Substituted ${scannedForm.replacements.length} value(s) in file upload to ${urlStr}`
);
}
}
} catch (e) {
console.warn('[Silent Send] FormData scan failed:', e);
}
}
// String body — JSON or raw text
if (typeof options.body === 'string') {
try {
// Try JSON
const body = JSON.parse(options.body);
const { modified, replacements } = processBody(body);
if (modified) {
options = { ...options, body: JSON.stringify(body) };
notifySubstitutions(replacements);
console.log(
`[Silent Send] Substituted ${replacements.length} value(s) in ${urlStr}`
);
}
} catch (e) {
// Not JSON — try raw string substitution (form data, etc.)
if (options.body.length > MIN_STRING_LENGTH) {
const result = substituteAll(options.body);
if (result.modified) {
options = { ...options, body: result.text };
notifySubstitutions(result.replacements);
console.log(
`[Silent Send] Substituted ${result.replacements.length} value(s) in form body`
);
}
}
}
}
}
return originalFetch.call(this, url, options);
} catch (e) {
// Something went wrong in Silent Send — never block the original request
console.warn('[Silent Send] Fetch interceptor error, passing through:', e);
return originalFetch.call(this, url, options);
}
const urlStr = typeof url === 'string' ? url : url?.url || '';
const method = (options?.method || 'GET').toUpperCase();
// Only intercept POST/PUT/PATCH
if (
(method === 'POST' || method === 'PUT' || method === 'PATCH') &&
options?.body && !shouldSkipUrl(urlStr)
) {
// FormData body — scan file uploads via DocumentScanner
if (options.body instanceof FormData && typeof globalThis.DocumentScanner !== 'undefined') {
try {
const scannedForm = await scanFormData(options.body);
if (scannedForm) {
options = { ...options, body: scannedForm.formData };
if (scannedForm.replacements.length > 0) {
notifySubstitutions(scannedForm.replacements);
console.log(
`[Silent Send] Substituted ${scannedForm.replacements.length} value(s) in file upload to ${urlStr}`
);
}
}
} catch (e) {
console.warn('[Silent Send] FormData scan failed:', e);
}
}
// String body — JSON or raw text
if (typeof options.body === 'string') {
try {
// Try JSON
const body = JSON.parse(options.body);
const { modified, replacements } = processBody(body);
if (modified) {
options = { ...options, body: JSON.stringify(body) };
notifySubstitutions(replacements);
console.log(
`[Silent Send] Substituted ${replacements.length} value(s) in ${urlStr}`
);
}
} catch (e) {
// Not JSON — try raw string substitution (form data, etc.)
if (options.body.length > MIN_STRING_LENGTH) {
const result = substituteAll(options.body);
if (result.modified) {
options = { ...options, body: result.text };
notifySubstitutions(result.replacements);
console.log(
`[Silent Send] Substituted ${result.replacements.length} value(s) in form body`
);
}
}
}
}
}
return originalFetch.call(this, url, options);
};
// Activate the fetch hook. If early-hook.js ran first (world: MAIN, document_start),