root/ubuntu-post-install
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix DB/admin password regeneration on rerun in 5 services

Browse Source 
Same bug class just fixed in mattermost.sh: immich, joplin, koha,
mail-archiver, and nextcloud all generated a fresh random
DB/admin password on every single run with no check for an
existing one. Each backs its database with a persistent volume, so
Postgres/MariaDB keeps the password from its first init while the
freshly overwritten .env (or config-main.env for koha) no longer
matches it — any rerun would have locked the app out of its own
database. koha, mail-archiver, and nextcloud also regenerated an
app-level admin login password the same way.

Found by cross-referencing every service with a DB password against
which ones actually guard reuse on rerun (only traccar.sh did,
already correctly) rather than waiting to be told about each one
individually.

Fix mirrors traccar.sh's existing pattern: read the password back out
of the existing .env/config file if present, only generate fresh when
there's genuinely nothing there yet.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NQkdAn3iG5A4WoqU9FHMaN
This commit is contained in:
Claude
2026-08-04 17:08:55 +00:00
parent cf3d4bf6de
commit f731efa2fa
5 changed files with 55 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/koha.sh
+20 -3
View File
@@ -336,10 +336,27 @@ install_koha() {
fi
# ── Passwords ─────────────────────────────────────────────────────────────
# Reused across reruns if already set — the MariaDB volume keeps
# DB_PASS/DB_ROOT_PASS from first init, and an already-created Koha admin
# account keeps its own KOHA_ADMIN_PASS; regenerating any of these on a
# rerun would lock the reinstall out of both the database and
# post-setup.sh's REST API login.
local DB_PASS DB_ROOT_PASS RABBIT_PASS
DB_PASS="$(generate_password 24)"
DB_ROOT_PASS="$(generate_password 24)"
RABBIT_PASS="$(generate_password 24)"
local _existing_koha_conf="$KOHA_DIR/config-main.env"
if [ -f "$_existing_koha_conf" ]; then
DB_PASS="$(grep '^DB_PASS=' "$_existing_koha_conf" | cut -d= -f2-)"
DB_ROOT_PASS="$(grep '^DB_ROOT_PASS=' "$_existing_koha_conf" | cut -d= -f2-)"
RABBIT_PASS="$(grep '^RABBIT_PASS=' "$_existing_koha_conf" | cut -d= -f2-)"
local _existing_admin_pass
_existing_admin_pass="$(grep '^KOHA_ADMIN_PASS=' "$_existing_koha_conf" | cut -d= -f2-)"
if [ -n "$_existing_admin_pass" ]; then
KOHA_ADMIN_PASS="$_existing_admin_pass"
log_info "Existing install detected — reusing its DB/admin passwords instead of what was just entered above, so this rebuild doesn't lock out the already-initialized database and admin account."
fi
fi
[ -n "${DB_PASS:-}" ] || DB_PASS="$(generate_password 24)"
[ -n "${DB_ROOT_PASS:-}" ] || DB_ROOT_PASS="$(generate_password 24)"
[ -n "${RABBIT_PASS:-}" ] || RABBIT_PASS="$(generate_password 24)"
# ── Create directories ────────────────────────────────────────────────────
mkdir -p "$KOHA_DIR/data"