Add OS detection; surface version in header; centralise pip installs
lib/common.sh:
- detect_os(): reads /etc/os-release into OS_DISTRO, OS_VERSION,
OS_CODENAME globals (exported, auto-called on source)
- ubuntu_version_ge(): numeric version comparison helper
- pip_user_install(): central wrapper for pip3 install --user so any
future version-specific flags are in one place
setup.sh:
- Both header banners now show detected OS line (e.g., "Ubuntu 24.04 (noble)")
- First-run path warns if not Ubuntu or < 24.04
services/sky-cam.sh, services/sync-cc.sh:
- Replace inline pip3 invocations with pip_user_install helper
https://claude.ai/code/session_01Y4dMKtkqkpvmgDKoRdzhTG
This commit is contained in:
@@ -96,6 +96,41 @@ save_site_config() {
|
||||
# Load immediately so all service modules inherit the values when sourced
|
||||
load_site_config
|
||||
|
||||
# ── OS detection ─────────────────────────────────────────────────────────────
|
||||
OS_DISTRO="unknown"
|
||||
OS_VERSION="unknown"
|
||||
OS_CODENAME="unknown"
|
||||
|
||||
detect_os() {
|
||||
[ -f /etc/os-release ] || return 0
|
||||
local key val
|
||||
while IFS='=' read -r key val; do
|
||||
val="${val//\"/}"
|
||||
case "$key" in
|
||||
ID) OS_DISTRO="$val" ;;
|
||||
VERSION_ID) OS_VERSION="$val" ;;
|
||||
VERSION_CODENAME|UBUNTU_CODENAME)
|
||||
[ "$OS_CODENAME" = "unknown" ] && OS_CODENAME="$val" ;;
|
||||
esac
|
||||
done < /etc/os-release
|
||||
export OS_DISTRO OS_VERSION OS_CODENAME
|
||||
}
|
||||
|
||||
# Return 0 (true) if the detected Ubuntu version is >= the argument (e.g., "24.04").
|
||||
ubuntu_version_ge() {
|
||||
[ "$OS_DISTRO" = "ubuntu" ] || return 1
|
||||
local a="${OS_VERSION//./}" b="${1//./}"
|
||||
[ "${a:-0}" -ge "${b:-0}" ] 2>/dev/null
|
||||
}
|
||||
|
||||
# pip install --user as actual user.
|
||||
# Centralised so any future version-specific pip flags land in one place.
|
||||
pip_user_install() {
|
||||
sudo -u "$ACTUAL_USER" pip3 install --user --quiet "$@"
|
||||
}
|
||||
|
||||
detect_os
|
||||
|
||||
# ── Pre-flight ───────────────────────────────────────────────────────────────
|
||||
require_root() {
|
||||
if [ "${EUID:-$(id -u)}" -ne 0 ]; then
|
||||
|
||||
Reference in New Issue
Block a user