From 64776731fbaf00ca749018bba383e55fe2708235 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sun, 28 Jun 2026 12:18:10 +0000
Subject: [PATCH] common.sh: fix Docker install failing silently in piped
 execution

Two bugs in require_docker:
1. apt post-install hooks (needrestart etc.) block on stdin which is
   at EOF when running via pipe; DEBIAN_FRONTEND=noninteractive skips them
2. bash's command hash table doesn't pick up a newly installed binary;
   hash -r flushes it so command -v docker finds /usr/bin/docker
Also moved usermod and success log after the binary check so [OK] only
prints when docker is actually reachable.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQJBvqzXeyuhhAcAA3Q5Wq
---
 lib/common.sh | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/lib/common.sh b/lib/common.sh
index 340828d..c6a00bb 100644
--- a/lib/common.sh
+++ b/lib/common.sh
@@ -170,14 +170,16 @@ require_docker() {
         return 0
     fi
 
-    # Official Docker convenience script — installs Docker CE + Compose plugin
-    if curl -fsSL https://get.docker.com | sh; then
-        if [ -n "$ACTUAL_USER" ] && [ "$ACTUAL_USER" != "root" ]; then
-            usermod -aG docker "$ACTUAL_USER" \
-                && log_info "Added $ACTUAL_USER to the docker group (re-login or run 'newgrp docker' to activate)"
-        fi
-        log_success "Docker installed ($(docker --version 2>/dev/null))"
-    else
+    # Official Docker convenience script — installs Docker CE + Compose plugin.
+    # DEBIAN_FRONTEND suppresses interactive apt hooks (needrestart etc.) that
+    # would block waiting on the piped stdin and cause a silent install failure.
+    export DEBIAN_FRONTEND=noninteractive
+    curl -fsSL https://get.docker.com | sh
+    local _rc=${PIPESTATUS[1]}
+    unset DEBIAN_FRONTEND
+    hash -r 2>/dev/null || true  # flush command hash so new binary is found
+
+    if [ "$_rc" -ne 0 ]; then
         log_error "Docker installation failed. Try manually: curl -fsSL https://get.docker.com | sh"
         return 1
     fi
@@ -186,6 +188,13 @@ require_docker() {
         log_error "Docker binary not found after install — something went wrong."
         return 1
     fi
+
+    if [ -n "$ACTUAL_USER" ] && [ "$ACTUAL_USER" != "root" ]; then
+        usermod -aG docker "$ACTUAL_USER" \
+            && log_info "Added $ACTUAL_USER to the docker group (re-login or run 'newgrp docker' to activate)"
+    fi
+
+    log_success "Docker installed ($(docker --version 2>/dev/null))"
 }
 
 # ── Command execution honoring dry-run ───────────────────────────────────────