From 9cf3765f83ab13fda696f004984206b3c1019726 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 1 Jul 2026 17:14:36 +0000 Subject: [PATCH] setup.sh: don't offer to install Caddy when CADDY_MODE is remote/none MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'Install Caddy now?' prompt ran regardless of the just-answered Caddy location question, so choosing 'remote' still asked whether to install Caddy locally — contradicting the choice made one prompt earlier. Gate it on CADDY_MODE being local (or unset, for configs predating the wizard split). Co-Authored-By: Claude Sonnet 4.6 Claude-Session: https://claude.ai/code/session_01LQJBvqzXeyuhhAcAA3Q5Wq --- setup.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/setup.sh b/setup.sh index 6a1ff8c..ab96298 100755 --- a/setup.sh +++ b/setup.sh @@ -273,8 +273,11 @@ if ! grep -q '^CADDY_MODE=' "$DOCKER_DIR/.config" 2>/dev/null; then fi fi -# 4) Offer Caddy first (most services proxy through it). -if [ -n "${SERVICE_GROUP[caddy]:-}" ] && ! is_installed caddy; then +# 4) Offer Caddy first (most services proxy through it) — only when Caddy is +# (or will be) local to this box. Remote/none mode means Caddy lives +# elsewhere, so installing it here would be wrong. +if [ -n "${SERVICE_GROUP[caddy]:-}" ] && ! is_installed caddy \ + && [ "${CADDY_MODE:-local}" = "local" ]; then echo "" OFFER_CADDY="" prompt_yn "Install Caddy now? It's the reverse proxy most services use. (y/n):" "y" OFFER_CADDY