Fix Authelia protection being dead code — reverse_proxy ran before the auth check
Both Caddy site block generators (the shared configure_caddy_for_service helper, and asterisk-digital-ocean.sh's own inline template) wrote reverse_proxy before the forward_auth/import authelia block. Caddy doesn't reorder repeats of the same directive within a block — forward_auth and reverse_proxy are the same directive family internally, so they run in the order written. With reverse_proxy first, it handled and terminated every request immediately; the auth check written after it never ran at all. Full bypass on every domain using either generator with Authelia protection, regardless of how correct the Authelia access_control rules themselves were — confirmed live against a config that was otherwise completely correct (default_policy: deny, explicit wildcard rule covering the affected domain). Affects every service that's ever passed `import authelia` or a forward_auth block through configure_caddy_for_service (asterisk.sh, wolf-pair.sh, and any future caller), plus asterisk-digital-ocean.sh's own site block. Moved the auth block before reverse_proxy in both generators. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015X1jRGHwrvovz2qkhKfDZi
This commit is contained in:
+8
-1
@@ -573,6 +573,14 @@ configure_caddy_for_service() {
|
||||
|
||||
# $SERVICE_NAME
|
||||
${SERVICE_DOMAIN} {
|
||||
# Auth (if any) must come before reverse_proxy — forward_auth is the
|
||||
# same directive family as reverse_proxy internally, and Caddy doesn't
|
||||
# reorder repeats of the same directive within a block; it runs them in
|
||||
# the order they're written. With reverse_proxy first, it would handle
|
||||
# and terminate every request immediately, so an auth check written
|
||||
# after it would be dead code that never runs — full bypass regardless
|
||||
# of what the auth server's own rules say.
|
||||
${EXTRA_CONFIG}
|
||||
reverse_proxy ${_BLOCK_UPSTREAM}
|
||||
|
||||
# Security headers
|
||||
@@ -588,7 +596,6 @@ ${SERVICE_DOMAIN} {
|
||||
output file /var/log/caddy/${SERVICE_DOMAIN}.log
|
||||
format json
|
||||
}
|
||||
${EXTRA_CONFIG}
|
||||
}
|
||||
CADDY_BLOCK
|
||||
)"
|
||||
|
||||
Reference in New Issue
Block a user