root/ubuntu-post-install
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make tab completion + backup pruning setup unconditional in setup.sh

Browse Source 
Both were only ever wired up from inside install_base(), so a box that
went straight to a direct single-service install (sudo ./setup.sh
beszel-agent, or any other service) without first explicitly running
`sudo ./setup.sh base` never got either — the direct-install branch exits
before the guided flow's own `run_service base` call is ever reached.
Confirmed live: tab completion doesn't work on a fresh box that installed
beszel-agent first.

Moved the call site to setup.sh itself, right after the --list/--status
early exits (which stay read-only and don't require root) and before every
other branch (configure, --remove, direct install, guided flow) — all of
which are downstream of that point regardless of which one actually runs.
Both helpers are idempotent and already no-prompt by design, so calling
them unconditionally on every invocation is safe; skipped under --dry-run
(with an equivalent [DRY-RUN] message) so a preview run doesn't write real
files.

install_base()'s own calls to both are now fully redundant (base.sh has no
standalone-bootstrap block, so install_base() is only ever reached
downstream of setup.sh's new call site) and removed, along with the two
DRY-RUN preview lines that described them there.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H4k6J1qXXyYxhGEgnJaMvn
This commit is contained in:
Claude
2026-08-11 13:27:35 +00:00
parent dade706b80
commit 459bde0f38
2 changed files with 37 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
setup.sh
+21
View File
@@ -267,6 +267,27 @@ if [ "$DO_LIST" = true ]; then list_services; exit 0; fi
# ── --status ─────────────────────────────────────────────────────────────────
if [ "$DO_STATUS" = true ]; then print_status; exit 0; fi
# ── Tab completion + backup pruning: always on, regardless of which branch ──
# below actually runs (configure, --remove, direct install, or the guided
# flow). Both used to only be wired up from inside install_base() — meaning
# a box that never explicitly ran `sudo ./setup.sh base` first (e.g. went
# straight to `sudo ./setup.sh beszel-agent`, the direct-install path, which
# exits before the guided flow's own `run_service base` call ever runs)
# never got either. Both are idempotent and no-prompt by design (see their
# own comments in services/base.sh), so running them unconditionally here on
# every invocation is safe. Skipped under --dry-run (would otherwise write
# real files during what's supposed to be a preview) and never reached by
# --list/--status above, which stay read-only and deliberately don't require
# root.
if [ "$DRY_RUN" = true ]; then
echo "[DRY-RUN] Would add setup.sh tab completion to ~/.bashrc (if not already there)"
echo "[DRY-RUN] Would set up daily pruning of old *.backup.* config files (systemd timer, if not already there)"
else
require_root
declare -F _base_setup_tab_completion >/dev/null 2>&1 && _base_setup_tab_completion
declare -F _base_setup_backup_pruning >/dev/null 2>&1 && _base_setup_backup_pruning
fi
# ── configure: show/update site-wide defaults ────────────────────────────────
if [ "${REQUESTED[*]:-}" = "configure" ]; then
require_root