root/sky-cam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CAM_NAME bug, set -x noise, wrong Python package in README

Browse Source 
daily_sunrise_video.sh: derive CAM_NAME from $1 (defaulting to SUNRISE_CAM)
instead of an undefined variable; this was causing empty image/output paths.

install.sh: pass $SUNRISE_CAM as argument to daily_sunrise_video.sh so it
matches the pattern used by every other per-camera script.

sunrise2mm.py: use SUNRISE_CAM config key (not the undefined CAM_NAME) to
locate the output directory; fixes silent path mismatch on non-default names.

4-seasons.sh: remove stray `set -x` that was flooding systemd logs with
shell trace output.

README.md: correct Python dependencies from `ephem` to `suntime pytz` to
match what sunrise.py actually imports.

https://claude.ai/code/session_01C4jbd3waXG3eKZYbGUjLUQ
This commit is contained in:
Claude
2026-04-19 21:56:33 +00:00
parent 16af99f0a3
commit 66fe1f46ca
5 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
4-seasons.sh
-1
View File
@@ -8,7 +8,6 @@
# Run once per day from cron (e.g. 01:00 daily). # Run once per day from cron (e.g. 01:00 daily).
set -euo pipefail set -euo pipefail
set -x
SCRIPT_DIR="$(dirname "$(realpath "$0")")" SCRIPT_DIR="$(dirname "$(realpath "$0")")"
source "$SCRIPT_DIR/sky-cam.conf" source "$SCRIPT_DIR/sky-cam.conf"
README.md
+1 -1
View File
@@ -22,7 +22,7 @@ Automated sky / timelapse camera scripts that produce:
Install Python dependencies: Install Python dependencies:
```bash ```bash
pip3 install ephem requests pip3 install suntime pytz requests
``` ```
--- ---
daily_sunrise_video.sh
+2
View File
@@ -17,6 +17,8 @@ SCRIPT_DIR="$(dirname "$(realpath "$0")")"
source "$SCRIPT_DIR/sky-cam.conf" source "$SCRIPT_DIR/sky-cam.conf"
export TZ="$TIMEZONE" export TZ="$TIMEZONE"
CAM_NAME="${1:-$SUNRISE_CAM}"
# ── Date / paths ────────────────────────────────────────────────────────────── # ── Date / paths ──────────────────────────────────────────────────────────────
current_date=$(date +%Y-%m-%d) current_date=$(date +%Y-%m-%d)
output_date=$(date +%Y-%m) output_date=$(date +%Y-%m)
install.sh
+1 -1
View File
@@ -86,7 +86,7 @@ OnSuccess=sky-cam-sunrise-upload.service
[Service] [Service]
Type=oneshot Type=oneshot
ExecStart=$SCRIPT_DIR/daily_sunrise_video.sh ExecStart=$SCRIPT_DIR/daily_sunrise_video.sh $SUNRISE_CAM
StandardOutput=journal StandardOutput=journal
StandardError=journal StandardError=journal
EOF EOF
sunrise2mm.py
+1 -1
View File
@@ -47,7 +47,7 @@ today_date_str = today.strftime("%Y-%m-%d") # e.g., "2024-11-05"
today_month_str = today.strftime("%Y-%m") # e.g., "2024-11" today_month_str = today.strftime("%Y-%m") # e.g., "2024-11"
# Set the full folder path for today's video # Set the full folder path for today's video
base_video_folder = os.path.join(config.get('MOVIES_DIR', ''), config.get('CAM_NAME', 'sunrise')) base_video_folder = os.path.join(config.get('MOVIES_DIR', ''), config.get('SUNRISE_CAM', 'sunrise'))
output_dir = os.path.join(base_video_folder, today_month_str, "sunrise-only") output_dir = os.path.join(base_video_folder, today_month_str, "sunrise-only")
# Check if the directory exists # Check if the directory exists